Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(12)

Issue 2899113003: Use all of the arguments to build the console messages

Created:
2 years, 4 months ago by Szabolcs David
Modified:
2 years, 4 months ago
CC:
devtools-reviews_chromium.org, v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Use all of the arguments to build the console messages Don't ignore the rest of the arguments in V8ConsoleMessage::createForConsoleAPI(). BUG=v8:5579

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M src/inspector/v8-console-message.cc View 3 chunks +11 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Szabolcs David
2 years, 4 months ago (2017-05-25 11:37:47 UTC) #3
jochen (gone - plz use gerrit)
dgozman is a better reviewer for this. From looking at the bug, it's not clear ...
2 years, 4 months ago (2017-05-26 11:42:06 UTC) #5
dgozman
Do you have any particular usecases for this? Note that many tests should fail now, ...
2 years, 4 months ago (2017-05-26 18:51:37 UTC) #8
Szabolcs David
On 2017/05/26 18:51:37, dgozman wrote: > Do you have any particular usecases for this? Note ...
2 years, 4 months ago (2017-05-26 21:40:36 UTC) #11
Szabolcs David
On 2017/05/26 18:51:37, dgozman wrote: > Do you have any particular usecases for this? Note ...
2 years, 4 months ago (2017-05-26 21:42:04 UTC) #12
dgozman
2 years, 4 months ago (2017-05-30 20:33:47 UTC) #13
Ok, let's try to go this route.

We'll need to disable some of unit_tests, browser_tests, content_unittests and
content_browsertests first, since they may depend on the same API you mention. I
kicked off linux_chromium_rel_ng bot for this.

Same goes for LayoutTests. See linux_trusty_blink_rel bot.

After temporary disabling the tests, we can commit this patch. Then after V8
roll into chromium, we'll have to change expectations and re-enable tests.

Powered by Google App Engine
This is Rietveld 408576698