Use all of the arguments to build the console messages

Use all of the arguments to build the console messages

Don't ignore the rest of the arguments in
V8ConsoleMessage::createForConsoleAPI().

BUG=v8:5579

[Szabolcs David, 2017-05-24 12:15:57]

Description was changed from

==========
Use all of the arguments to build the console messages

Don't ignore the rest of the arguments in
V8ConsoleMessage::createForConsoleAPI().

BUG=v8:5579
==========

to

==========
Use all of the arguments to build the console messages

Don't ignore the rest of the arguments in
V8ConsoleMessage::createForConsoleAPI().

BUG=v8:5579
==========

[Szabolcs David, 2017-05-24 12:15:57]

davidsz@inf.u-szeged.hu changed reviewers:
+ jochen@chromium.org

[jochen (gone - plz use gerrit), 2017-05-26 11:42:06]

jochen@chromium.org changed reviewers:
+ dgozman@chromium.org

[jochen (gone - plz use gerrit), 2017-05-26 11:42:06]

dgozman is a better reviewer for this. From looking at the bug, it's not clear
to me whether this change is actually desirable.

Note that in general, it would be great to have a test for such changes.

[dgozman, 2017-05-26 18:50:12]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-26 18:50:22]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dgozman, 2017-05-26 18:51:37]

Do you have any particular usecases for this? Note that many tests should fail
now, since they only expected the first argument (e.g. some browser_tests,
layout tests, maybe more).

I'm not sure it's worth changing unless you have a very convincing reason for
that.

[commit-bot: I haz the power, 2017-05-26 19:18:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-26 19:18:24]

Dry run: This issue passed the CQ dry run.

[Szabolcs David, 2017-05-26 21:40:36]

On 2017/05/26 18:51:37, dgozman wrote:
> Do you have any particular usecases for this? Note that many tests should fail
> now, since they only expected the first argument (e.g. some browser_tests,
> layout tests, maybe more).
> 
> I'm not sure it's worth changing unless you have a very convincing reason for
> that.

I'm embedding Chromium into an application and I would like to rely on the
corresponding function of the content API:
WebContentsDelegate::DidAddMessageToConsole(...)
https://cs.chromium.org/chromium/src/content/public/browser/web_contents_dele...

... but it doesn't support multiple arguments. Here are some bugreports from the
clients related to this:

CEF:
https://bitbucket.org/chromiumembedded/cef/issues/324/only-the-first-consolel...
QtWebEngine: https://bugreports.qt.io/browse/QTBUG-56384

[Szabolcs David, 2017-05-26 21:42:04]

On 2017/05/26 18:51:37, dgozman wrote:
> Do you have any particular usecases for this? Note that many tests should fail
> now, since they only expected the first argument (e.g. some browser_tests,
> layout tests, maybe more).
> 
> I'm not sure it's worth changing unless you have a very convincing reason for
> that.

I'm embedding Chromium into an application and I would like to rely on the
corresponding function of the content API:
WebContentsDelegate::DidAddMessageToConsole(...)
https://cs.chromium.org/chromium/src/content/public/browser/web_contents_dele...

... but it doesn't support multiple arguments. Here are some bugreports from the
clients related to this:

CEF:
https://bitbucket.org/chromiumembedded/cef/issues/324/only-the-first-consolel...
QtWebEngine: https://bugreports.qt.io/browse/QTBUG-56384

[dgozman, 2017-05-30 20:33:47]

Ok, let's try to go this route.

We'll need to disable some of unit_tests, browser_tests, content_unittests and
content_browsertests first, since they may depend on the same API you mention. I
kicked off linux_chromium_rel_ng bot for this.

Same goes for LayoutTests. See linux_trusty_blink_rel bot.

After temporary disabling the tests, we can commit this patch. Then after V8
roll into chromium, we'll have to change expectations and re-enable tests.